Bug 1877374: Remove unused bootstrap etcd cert generation mechanism #4150

ironcladlou · 2020-09-09T13:43:30Z

The cluster-etcd-operator render command now handles bootstrap certificate
generation. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

Depends on openshift/cluster-etcd-operator#438
Backport of #3995

The cluster-etcd-operator render command now handles bootstrap certificate generation[1]. This patch deletes the now unused client/server bootstrap etcd cert generation logic. [1] openshift/cluster-etcd-operator#412

openshift-ci-robot · 2020-09-09T13:43:35Z

@ironcladlou: This pull request references Bugzilla bug 1877374, which is invalid:

expected dependent Bugzilla bug 1876091 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1877374: Remove unused bootstrap etcd cert generation mechanism

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ironcladlou · 2020-09-09T21:29:35Z

output of cluster bot run:

test e2e-all openshift/cluster-etcd-operator#438,openshift/installer#4150

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1303747503237107712

Looks like the run failed but not because of bootstrapping or anything related to cert changes.

jstuever · 2020-09-21T23:20:08Z

/retest

jstuever · 2020-09-21T23:20:14Z

/test e2e-azure
/test e2e-aws-upi
/test e2e-vsphere
/test e2e-gcp

ironcladlou · 2020-09-22T12:39:34Z

/retest

jstuever · 2020-09-24T16:43:23Z

/retest

openshift-ci-robot · 2020-09-24T18:01:10Z

@ironcladlou: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	`220a999`	link	`/test e2e-openstack`
ci/prow/e2e-vsphere	`220a999`	link	`/test e2e-vsphere`
ci/prow/e2e-ovirt	`220a999`	link	`/test e2e-ovirt`
ci/prow/e2e-aws-scaleup-rhel7	`220a999`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-aws	`220a999`	link	`/test e2e-aws`
ci/prow/e2e-gcp	`220a999`	link	`/test e2e-gcp`
ci/prow/e2e-aws-upi	`220a999`	link	`/test e2e-aws-upi`
ci/prow/e2e-azure	`220a999`	link	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hexfusion · 2020-10-06T14:33:23Z

/hold
for openshift/cluster-etcd-operator#438

hexfusion · 2020-10-06T14:41:57Z

/bugzilla refresh

openshift-ci-robot · 2020-10-06T14:42:02Z

@hexfusion: This pull request references Bugzilla bug 1877374, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1876091 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1876091 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2020-10-22T13:26:22Z

@abhinavdahiya we received the ok to backport openshift/cluster-etcd-operator#438 can you approve this, please?

bparees · 2020-10-22T14:45:49Z

@hexfusion you asked me to tag this for cherry picking but it's held, not approved, and not lgtm'd. It needs all those things before it can be considered for CPA.

does openshift/cluster-etcd-operator#438 need to be held to ensure we don't get only half the fix?

hexfusion · 2020-10-29T00:28:52Z

/retest
/hold cancel

staebler · 2020-10-29T00:34:32Z

/approve

hexfusion · 2020-10-29T02:06:11Z

/test all

hexfusion · 2020-10-29T16:20:01Z

since #4283 merged we should be unblocked

/test all

hexfusion · 2020-10-29T17:10:46Z

/retest

openshift-merge-robot · 2020-10-29T18:10:25Z

@ironcladlou: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp	`220a999`	link	`/test e2e-gcp`
ci/prow/e2e-azure	`220a999`	link	`/test e2e-azure`
ci/prow/e2e-ovirt	`220a999`	link	`/test e2e-ovirt`
ci/prow/e2e-aws-scaleup-rhel7	`220a999`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-aws-upi	`220a999`	link	`/test e2e-aws-upi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jstuever · 2020-10-29T18:39:35Z

/lgtm

openshift-ci-robot · 2020-10-29T18:40:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-10-29T18:47:45Z

@ironcladlou: All pull requests linked via external trackers have merged:

Bugzilla bug 1877374 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1877374: Remove unused bootstrap etcd cert generation mechanism

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Remove unused bootstrap etcd cert generation mechanism

220a999

The cluster-etcd-operator render command now handles bootstrap certificate generation[1]. This patch deletes the now unused client/server bootstrap etcd cert generation logic. [1] openshift/cluster-etcd-operator#412

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 9, 2020

openshift-ci-robot requested review from jhixson74 and jstuever September 9, 2020 13:43

hexfusion mentioned this pull request Sep 9, 2020

[wip] bootkube.sh: handle retry of etcd-signer gracefully #4149

Closed

hexfusion mentioned this pull request Oct 6, 2020

Bug 1877374: Render bootstrap certificates openshift/cluster-etcd-operator#438

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 6, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 6, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020

openshift-ci-robot assigned jstuever Oct 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020

jstuever approved these changes Oct 29, 2020

View reviewed changes

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2020

openshift-merge-robot merged commit a1f4344 into openshift:release-4.5 Oct 29, 2020

staebler mentioned this pull request Nov 2, 2020

OCP 4.5.x : bootkube.sh[2365]: Error: unknown flag: --etcd-ca-key #4332

Closed

Bug 1877374: Remove unused bootstrap etcd cert generation mechanism #4150

Bug 1877374: Remove unused bootstrap etcd cert generation mechanism #4150

Uh oh!

Conversation

ironcladlou commented Sep 9, 2020

Uh oh!

openshift-ci-robot commented Sep 9, 2020

Uh oh!

ironcladlou commented Sep 9, 2020

Uh oh!

jstuever commented Sep 21, 2020

Uh oh!

jstuever commented Sep 21, 2020

Uh oh!

ironcladlou commented Sep 22, 2020

Uh oh!

jstuever commented Sep 24, 2020

Uh oh!

openshift-ci-robot commented Sep 24, 2020

Uh oh!

hexfusion commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hexfusion commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

hexfusion commented Oct 22, 2020

Uh oh!

bparees commented Oct 22, 2020

Uh oh!

hexfusion commented Oct 29, 2020

Uh oh!

staebler commented Oct 29, 2020

Uh oh!

hexfusion commented Oct 29, 2020

Uh oh!

hexfusion commented Oct 29, 2020

Uh oh!

hexfusion commented Oct 29, 2020

Uh oh!

openshift-merge-robot commented Oct 29, 2020

Uh oh!

jstuever commented Oct 29, 2020

Uh oh!

openshift-ci-robot commented Oct 29, 2020

Uh oh!

openshift-ci-robot commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hexfusion commented Oct 6, 2020 •

edited

Loading